Fast-SL Algorithm - Githubissues

opencobra / cobratoolbox

The COnstraint-Based Reconstruction and Analysis Toolbox. Documentation:

https://opencobra.github.io/cobratoolbox

Other

241 stars 306 forks source link

Fast-SL Algorithm #2107

Closed SomyaVerma27 closed 1 year ago

SomyaVerma27 commented 1 year ago

Updated and added fast-sl algorithm

I hereby confirm that I have:

[x] Tested my code on my own machine
[x] Followed the guidelines in the Contributing Guide
[x] Selected develop as a target branch (top left drop-down menu)

(Note: You may replace [ ] with [X] to check the box)

tpfau commented 1 year ago

Could you rename the folder from "Synthetic Lethals" to syntheticlethals ?
I guess there are several functions missing in the PR at the moment, (singleSL, doubeLS, tripleSL). Is it intentional that the code saves its outputs to files instead of returning it from the call?

SomyaVerma27 commented 1 year ago

Hi Thomas,

I have made the necessary changes.

SomyaVerma27 commented 1 year ago

Moved tutorial to COBRA.tutorials. I have opened a pull request in https://github.com/opencobra/COBRA.tutorials for the same change. Find the pull request here: https://github.com/opencobra/COBRA.tutorials/pull/198

SomyaVerma27 commented 1 year ago

Hi Ronan, Is there any update regarding this PR?