opencobra / cobratoolbox

The COnstraint-Based Reconstruction and Analysis Toolbox. Documentation:
https://opencobra.github.io/cobratoolbox
Other
252 stars 317 forks source link

readCbModel/TranslateSBML doesn't recognize filepath correctly when using pop-up/dialog #862

Closed cjos238 closed 7 years ago

cjos238 commented 7 years ago

Description When using the pop-up version of the following command model = readCbModel; If the user points to the filepath using pop-up/dialog, the function continues to look in the current directory.

Example Following error is generated, even after pointing to the file in "E:\Box\matlab\celegans\iCEL1273_2.xml" Error using TranslateSBML _File E:\Box\matlab\celegans\tissue_GFP\iCEL12732.xml does not exist on this path

Error in readSBML (line 31) modelSBML = TranslateSBML(fileName,0,0,[1 1]);

Error in readCbModel (line 206) model = readSBML(fileName,defaultBound);

Possible fixes It was implemented in the previous version of the function.

I hereby confirm that I have:

laurentheirendt commented 7 years ago

Fixed by PR #863. Thanks @cjos238 and @syarra