Open jjkoehorst opened 6 years ago
Hi @jjkoehorst, thank you for the thorough report. I'm still finishing up #441 and #132 which will update memote new
and correct the memote history + report. The documentation also needs updating, this is tracked in #379 and #417.
I had noticed the docker image not being updated properly. This is a problem with the new PyPI that takes much longer until a new deployed version is available and thus breaks the build of the docker image. Can you open an issue for that, please?
Just saw the email... :) and I would like to continue with the integration of the gitlab base. Any news on the docker image and latest memote?
The docker image is now being built by a (daily) cron job on Travis. At the moment the image is only built when a new memote version is out but I'm thinking of changing that to just rebuild daily such that dependencies get updated once in a while.
The new workflows are documented if they have changed at all.
What else is needed for you to proceed with Gitlab?
Great!... I see you made it such that a normal user is running in the docker image? I might need to install some additional tools but since it has no sudo rights I am running against a wall..
https://gitlab.com/jjkoehorst/memote-demo2/blob/master/.gitlab-ci.yml
'which ssh-agent || ( apt-get update -y && apt-get install openssh-client -y )'
Would you mind making a PR against https://github.com/opencobra/memote-docker/blob/master/Dockerfile to adjust the Dockerfile as needed?
I think for now I prefer carrying extra dependencies in the memote image as long as they can be justified by enabling additional workflows. I would like to avoid running memote as root inside the container.
Basics seems to work now:
https://gitlab.com/jjkoehorst/memote-demo3
I am using the following configuration: https://gitlab.com/jjkoehorst/memote-demo3/blob/master/.gitlab-ci.yml (can create a pull request for that when we all agree on the commands used (maybe there are things that I have missed or are redundant)
Using the following variables $GITREPO and $SSH_PRIVATE_KEY
I will write a more extensive documentation on how to generate a private and public key. Where to add them on gitlab. How to change the git url that memote makes to a new empty repo on gitlab. Set the variables needed for the runner.
I am currently looking into the gh-pages and how to use this in gitlab as it is possible.
https://jjkoehorst.gitlab.io/memote-demo3/
But it does not seem to show everything? I only used the index.html file.
and this is the runner for the gh-pages:
https://gitlab.com/jjkoehorst/memote-demo3/blob/gh-pages/.gitlab-ci.yml
What's the best way for me to comment on that gitlab runner configuration?
Very good question
Not sure actually. We can make a google document? I don’t see line comments options yet maybe via a pull request?
On 14 Aug 2018, at 11:13, Moritz E. Beber notifications@github.com wrote:
What's the best way for me to comment on that gitlab runner configuration?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opencobra/memote/issues/453#issuecomment-412807654, or mute the thread https://github.com/notifications/unsubscribe-auth/AEQ7kwEzUJeMbMICxh8LIcKUm-8FVWHmks5uQpTHgaJpZM4Us3d0.
Okay, I'll make a pull request. Prefer that to a Google doc.
You can only comment on diffs not on full files so I just made a full file commit:
https://gitlab.com/jjkoehorst/memote-demo3/commit/660bc41d556146ec9650390350760afbfb7502d3
Just noticed and perhaps most importantly:
And this is a continuation of (as I ran into docker version issue)...
https://github.com/opencobra/memote/issues/260
I am working on the gitlab runner implementation and am working from the docker image to perform thorough testing.
I had an old git repo which does not fit the current format so I created a new one using
memote new
<enter - enter - enter> all defaults
cd memote_model_repository
Following the documentation at:
https://memote.readthedocs.io/en/latest/getting_started.html#benchmark
Offline, local or private workflow:
memote run
critical: Working with a repository requires a storage location.
Using:
memote run --location location model.xml
Does work but the folder needs to exist. Perhaps we can automatically create the folder when it doesn't? (should I open a new ticket for this?)
When looking into using the history (keep in mind this is a new git repo using the default settings with no commit yet...)
memote report history
This will give a:
which makes sense but is not clear in the documentation
Using
memote report history Results/
in which the content is
results in:
The basics works! but its still a work in progress
The gitlab repository used: https://gitlab.com/wurssb/memote-demo/tree/master
The runner file used: https://gitlab.com/wurssb/memote-demo/blob/master/.gitlab-ci.yml
The resulting GitHub-pages: https://gitlab.com/wurssb/memote-demo/tree/gh-pages/ Gitlab is not doing anything with them but I can make it so that it will make use of the gitlab pages if requested?
The entire git run: https://gitlab.com/wurssb/memote-demo/-/jobs/75803125
The nice thing is that it can make use of the gitlab computational resources. Not sure if travis is hosted by GitHub or you need to set this up yourself?
Will update soon with new information but the documentation looks a bit off..