search

opencobra / memote

memote – the genome-scale metabolic model test suite
https://memote.readthedocs.io/
Apache License 2.0
127 stars 27 forks source link

added 's' to end of 'kegg.gene' to be compliant with identifiers.org namespace #586

Closed gregmedlock closed 5 years ago

gregmedlock commented 5 years ago

Apologies for the small change, but the annotation search process was looking for the namespace "kegg.gene" rather than "kegg.genes". If users use "kegg.gene", the identifier.org URLs that are generated in SBML are incorrect.

See https://www.ebi.ac.uk/miriam/main/datatypes/MIR:00000070 for the definition and http://identifiers.org/kegg.genes/syn:ssr3451 for an example.

codecov[bot] commented 5 years ago

Codecov Report

Merging #586 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #586   +/-   ##
========================================
  Coverage    80.04%   80.04%           
========================================
  Files           57       57           
  Lines         2926     2926           
  Branches       385      385           
========================================
  Hits          2342     2342           
  Misses         518      518           
  Partials        66       66
Impacted Files Coverage Δ
memote/support/annotation.py 97.5% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e849c5...8b7cd10. Read the comment docs.