opencobra / memote

memote – the genome-scale metabolic model test suite
https://memote.readthedocs.io/
Apache License 2.0
127 stars 27 forks source link

Fix topology tests #589

Closed Midnighter closed 5 years ago

Midnighter commented 5 years ago

Metabolites with irreversible exchange reactions were falsely identified as orphans. Not consumed and not produced metabolites were detected opening all boundary reactions. This has changed to only opening exchanges.

codecov[bot] commented 5 years ago

Codecov Report

Merging #589 into develop will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #589      +/-   ##
===========================================
+ Coverage    80.04%   80.07%   +0.03%     
===========================================
  Files           57       57              
  Lines         2926     2931       +5     
  Branches       385      386       +1     
===========================================
+ Hits          2342     2347       +5     
  Misses         518      518              
  Partials        66       66
Impacted Files Coverage Δ
memote/suite/tests/test_consistency.py 95.29% <ø> (ø) :arrow_up:
memote/support/consistency.py 97.07% <100%> (+0.03%) :arrow_up:
memote/suite/tests/test_basic.py 100% <100%> (ø) :arrow_up:
memote/support/helpers.py 94% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7d6fbe...2c25fd2. Read the comment docs.