gregmedlock commented 5 years ago

[ ] fix #x (issue number)
[x] description of feature/fix
[x] tests added/passed
[x] add an entry to the next release

seed.reaction has been added to the namespace for identifiers.org, so this adds seed.reaction to the reaction annotation databases and the associated unit tests.

Midnighter commented 5 years ago

Including the SEED reaction identifiers is a welcome addition, however, so far I couldn't find it on identifiers.org. Where do you take seed.reaction from?

codecov[bot] commented 5 years ago

Codecov Report

Merging #599 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #599   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files           59      59           
  Lines         3095    3095           
  Branches       423     423           
=======================================
  Hits          2470    2470           
  Misses         552     552           
  Partials        73      73

Impacted Files	Coverage Δ
memote/support/annotation.py	`100% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d398fcc...f9d774c. Read the comment docs.

gregmedlock commented 5 years ago

It should be listed and searchable within 24 hours--I just got the confirmation from the identifiers.org team. Here's a direct link they shared with me: https://www.ebi.ac.uk/miriam/main/datatypes/MIR:00000692

Everything is up and running, they just haven't updated the frontend/search, e.g. this is active: http://identifiers.org/seed.reaction/rxn00001

opencobra / memote

feat: add seed.reaction namespace for reaction annotations #599

Codecov Report