search

opencobra / memote

memote – the genome-scale metabolic model test suite
https://memote.readthedocs.io/
Apache License 2.0
127 stars 27 forks source link

fix: biomass SBO annotation test #601

Closed gregmedlock closed 5 years ago

gregmedlock commented 5 years ago

The test for the biomass SBO term was testing for absence of the term but the assert statement at the end of the test was expecting the rest of the function to be testing for absence of the term.

I added an explicit test for the SBO biomass term for now... I was worried that if it were just wrapped into on of the other cases, or in a set of parameters, it might not be clear that the term being tested needed to be biomass (e.g. the other tests just have arbitrary SBO terms).

codecov[bot] commented 5 years ago

Codecov Report

Merging #601 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #601   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files           59      59           
  Lines         3095    3095           
  Branches       423     423           
=======================================
  Hits          2470    2470           
  Misses         552     552           
  Partials        73      73
Impacted Files Coverage Δ
memote/suite/tests/test_sbo.py 82.22% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34679e3...1ed56d0. Read the comment docs.