opencobra / memote

memote – the genome-scale metabolic model test suite
https://memote.readthedocs.io/
Apache License 2.0
125 stars 26 forks source link

Fix external #607

Closed Midnighter closed 5 years ago

Midnighter commented 5 years ago
Midnighter commented 5 years ago

add_boundary raises a RuntimeError since cobra 0.14.2 if it cannot identify the external compartment. This was the fastest way I could see to circumvent that.

codecov[bot] commented 5 years ago

Codecov Report

Merging #607 into develop will decrease coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #607      +/-   ##
===========================================
- Coverage     79.8%   79.74%   -0.07%     
===========================================
  Files           59       59              
  Lines         3095     3095              
  Branches       423      423              
===========================================
- Hits          2470     2468       -2     
- Misses         552      553       +1     
- Partials        73       74       +1
Impacted Files Coverage Δ
memote/suite/tests/test_thermodynamics.py 88.88% <0%> (-11.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48a946d...5d83c68. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #607 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #607   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files           59      59           
  Lines         3095    3095           
  Branches       423     423           
=======================================
  Hits          2470    2470           
  Misses         552     552           
  Partials        73      73
Impacted Files Coverage Δ
memote/support/helpers.py 94% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48a946d...5d83c68. Read the comment docs.