search

opencobra / memote

memote – the genome-scale metabolic model test suite
https://memote.readthedocs.io/
Apache License 2.0
125 stars 26 forks source link

Post-release hotfix! #638

Closed ChristianLieven closed 5 years ago

ChristianLieven commented 5 years ago

Fixes issue with clashing dependencies and memote online not working on the first try!

codecov[bot] commented 5 years ago

Codecov Report

Merging #638 into develop will decrease coverage by 0.36%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #638      +/-   ##
===========================================
- Coverage     85.4%   85.03%   -0.37%     
===========================================
  Files           59       59              
  Lines         3234     3248      +14     
  Branches       434      436       +2     
===========================================
  Hits          2762     2762              
- Misses         384      398      +14     
  Partials        88       88
Impacted Files Coverage Δ
memote/suite/cli/runner.py 51.7% <0%> (-1.98%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d51f6ef...aed5933. Read the comment docs.

phantomas1234 commented 5 years ago

Shouldn't there be a finally somewhere in changes?

phantomas1234 commented 5 years ago

Should merge anyhow if it breaks memote online currently