opencobra / memote

memote – the genome-scale metabolic model test suite
https://memote.readthedocs.io/
Apache License 2.0
123 stars 26 forks source link

Fix find biomass #693

Closed Midnighter closed 3 years ago

Midnighter commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #693 into develop will decrease coverage by 0.03%. The diff coverage is 91.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #693      +/-   ##
===========================================
- Coverage    83.07%   83.04%   -0.04%     
===========================================
  Files           49       49              
  Lines         2653     2671      +18     
  Branches       435      441       +6     
===========================================
+ Hits          2204     2218      +14     
- Misses         357      361       +4     
  Partials        92       92              
Impacted Files Coverage Δ
src/memote/support/helpers.py 94.61% <91.17%> (-0.02%) :arrow_down:
src/memote/experimental/tabular.py 88.23% <100.00%> (ø)
src/memote/suite/cli/reports.py 75.55% <0.00%> (-2.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c6739e...c7a9b47. Read the comment docs.

BenjaSanchez commented 3 years ago

@Midnighter just to confirm that this solves the issue we had in yeast-GEM: only one biomass rxn is identified with the latest memote release :)