Closed carrascomj closed 9 months ago
Hi , thanks for working on this, have there been any updates? I'm new to both github and memote.
@jthom17 I was going to have another developer working on this to polish the github-user interaction but that could not happen in the end. I see some people forking this to use it, so, if it is useful, I can push it to pass the CI-CD tests and set it as ready for review.
I just used this fork, and it worked for me!
Any updates or timeline?
@JamesPino this PR is ready to use but there are three things required to merge it:
I cannot say anything about the timeline because memote is mainly maintained by people in their spare time, and reviewing code can take up some time. In the meantime, you can always install it from the downstream branch:
pip install "git+https://github.com/carrascomj/memote.git@refactor-github-actions"
And please let me know if you find any bug in the implementation!
Everything seems to work. The github actions report have expired. Is it possible to rerun them? We are trying to leverage this more, so if I can review and write more tests to get it merged please let me know.
Is it possible to add a feature to add memote gh-actions files to an existing repo, rather than build a repo from memote online ?
@carrascomj checking back in. What can I do to get this merged? I can review or write additional tests as needed. The current tests are failing, but results are not logged anymore.
Can someone with sufficient privileges rerun the tests? I would love it if memote could use github actions
I have rerun the workflow. If I remember it right, I am doing something wrong at either the test or at the time of creating a deployment branch if it does not exist. Additionally, python3.6 has to be deprecated. Feel free to ping me next week if I haven't got back to this.
Patch coverage: 76.47%
and project coverage change: +3.37%
:tada:
Comparison is base (
3687f37
) 73.60% compared to head (941adeb
) 76.98%.:exclamation: Current head 941adeb differs from pull request most recent head 047bd99. Consider uploading reports for the commit 047bd99 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It seems like the tests are now passing. python3.6 workflows have to be removed (and maybe add 3.9, 3.10 and 3.11 but that should be another PR); pandas has to be pinned to solve the 3.7 errors; and no idea about the 3.7 Linux workflow.
@Midnighter tests are passing now, if you have some time. If not, maybe others can jump in.
I had to move forward the supported python versions in this PR.
I'll do my best to review this in a timely fashion now. I appreciate the work in any case 👍🏼
Thank you! Looking forward to the merge
Are you allowed to merge (maybe squash; however you prefer) it, @Midnighter? The pending codecov workflow does not allow me to do it.
Need to do something about the codecov setup. I also still see Travis in the checks which is weird.
This is accompanied with a PR to cookiecutter-memote.
Github changed the API for authentication (see deprecation notice):
Thus, the command line option
memote online
has to be updated accordingly.For the reasons outlined above, it is easier to replace travis with github actions than to figure out the new workflow; the difficulty lies in programmatically generating github's token, which does not seem to be possible anymore. Github actions does not need an user-created token since it has access to its own token via a secret.
As of now, the user has to create a token following github documentation to specify the token and add it as an argument:
Or, alternatively, have an environment variable
GITHUB_TOKEN
set to the token.It would be better to have a setup more similar to the web application flow, where the user would be pointed to create a token during
memote new
.