Open WalkerKnapp opened 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
12338a6
) 74.85% compared to head (8358d2a
) 74.85%.:exclamation: Current head 8358d2a differs from pull request most recent head 0666f99. Consider uploading reports for the commit 0666f99 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This fix is related to issue #315, but it is a band-aid solution for the current state of database IDs, not an automatic solution as suggested in the issue.
The Regex patterns which are used to match against annotation IDs in
test_*_annotation_wrong_ids
tests have gone out of date since they were last updated. This PR replaces out-of-date ID patterns with the latest versions retrieved from https://registry.identifiers.org/registry.I first noticed this problem when evaluating a model which uses a refseq id in the format
WP_*
, which is now a valid ID. While updating this pattern, I noticed that others have gone out of date as well and have updated them too.All previous tests in
tests/test_for_support/test_for_annotation.py
still apply and pass, and no additional functionality which would require tests has been introduced.