Closed cdiener closed 1 year ago
These changes seem rather small but potentially quite significant. Did you run the cobrapy test suite with this optlang version, for example?
Yes of course (see below). I detected the issue in the cobrapy codebase which is currently broken for all new installs since it will pull in sympy 1.12.
For consistency we probably want to derive from the symengine Dummy class as well. Does not work, but symengine Symbols are unique by default anyways.
Some changes in sympy 1.12 broke the previous hack in place to make the optlang
Symbol
class unique. However, sympy now has theDummy
class for a Symbol where symbols with the same name are unique, so we now derive from that class. SymengineSymbols
are unique by default, so no changes here.Also fixes some warnings due to updates in jsonschema and scipy.