opencoca / lt2d_school

Meet freely
https://codesandbox.io/s/github/opencoca/Latitude
1 stars 6 forks source link

Add Share Room's app #13

Open opencoca opened 3 years ago

opencoca commented 3 years ago

Create a dedicated route to a given room's app

Expose URL to rooms apps and provide QR code for quick access.

shadowlerone commented 3 years ago

wouldn't this go on the API side?

shadowlerone commented 3 years ago

okay. app endpoint done. working on creating the QR Code. will make pull request later

opencoca commented 3 years ago

wouldn't this go on the API side?

As we already expose the apps via the API, it's expedient to generate the QR codes client-side rather than send them as images.

Also added support for multiple meeting platforms is: https://github.com/opencoca/lt2d_school/blob/e29692798f1ab4560052b2d6203aaba6695b7c3b/src/pages/meeting/index.vue#L132

opencoca commented 3 years ago

We will wait until our TODO on our style framework and our standardized modals is complete.

opencoca commented 3 years ago

Modal is almost finished being added to the style framework just running into a minor issue with everything above the button triggering the button https://codepen.io/openco/pen/BjqVEo?editors=1100

shadowlerone commented 3 years ago

that's because its height is set to 100% image The button is within the modal container and is taking up the full height of the modal container

shadowlerone commented 3 years ago

I think I might wrap the modal opening and closing into the menu toggles system I'm currently using for simplicity and flexibility