search

opencodeiiita / News_Scraping

5 stars 23 forks source link

Solve Task 2 #10

Closed criticic closed 8 months ago

criticic commented 8 months ago

Issue: #2

opencode-bot commented 8 months ago

Hey @criticic

Thanks for opening this PR 🚀. Mentor will review your pull request soon and till then, keep contributing and stay calm.

Thanks for contributing in OpenCode'23 ✨✨!

Shashank1985 commented 8 months ago

@criticic your code must return a csv file, pls do the required changes

criticic commented 8 months ago

okay sure

criticic commented 8 months ago

@Shashank1985 I have updated the notebook

Shashank1985 commented 8 months ago

Screenshot from 2023-12-19 15-40-05 please keep all the titles in the same cell, this is not what we were looking for. The scraped headlines should be in the same cell.

criticic commented 8 months ago

hmm I opened it on a online csv reader and it appeared fine

criticic commented 8 months ago

even in viscose it shows correct formatting,

image
criticic commented 8 months ago

I think in some apps it does not automatically detect the delimiter "|", so you'd have to add it.

image
Shashank1985 commented 8 months ago

@criticic ok approved

opencode-bot commented 8 months ago

Hey @criticic

Your PR has been merged 🥳🥳 and you have earned 20 points.

Thanks for contributing in OpenCode'23 ✨✨