opencodeiiita / Opencode-Collaborative-19

Collaborative website for OpenCode-2019
https://opencodeiiita.github.io/Opencode-Collaborative-19/
MIT License
35 stars 190 forks source link

Implement lazy loading on all sections. #87

Open ekanban opened 5 years ago

ekanban commented 5 years ago

This issue couldn't be solved in the last edition of OpenCode. Let's see if someone can solve it this time around!

opencodebot[bot] commented 5 years ago

Thanks for opening this issue! ok

lo0oper commented 5 years ago

just mentioning the comment to claim it is enough for claiming it right? i want to claim this

lo0oper commented 5 years ago

@opencodebot claim

opencodebot[bot] commented 5 years ago

Welcome to OpenCode! Invitation has been sent,check your mail. Please accept it to contribute in this repo and again claim this issue. See the further instructions here.

lo0oper commented 5 years ago

@opencodebot claim

opencodebot[bot] commented 5 years ago

Welcome to OpenCode! Invitation has been sent,check your mail. Please accept it to contribute in this repo and again claim this issue. See the further instructions here.

ananya commented 5 years ago

@lo0oper issue is assigned to you

zerefwayne commented 5 years ago

@lo0oper Check your mail and accept the invitation as well.

lo0oper commented 5 years ago

checked , got it . do i need to do anything else to claim the issue.

ekanban commented 5 years ago

Nope. This issue is yours.

lo0oper commented 5 years ago

thankx got it....

lo0oper commented 5 years ago

okay... can you tell me where to start with it ?

On Sun, Jan 13, 2019 at 12:43 PM Ekansh Bansal notifications@github.com wrote:

Assigned #87 https://github.com/opencodeiiita/Opencode-Collaborative-19/issues/87 to @lo0oper https://github.com/lo0oper.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/opencodeiiita/Opencode-Collaborative-19/issues/87#event-2070413113, or mute the thread https://github.com/notifications/unsubscribe-auth/ApsU8sOqlYTsPyr4DcSnP92wxVKw1hfnks5vCtyGgaJpZM4Z9Ay_ .

vishnuk7 commented 5 years ago

@opencodebot claim

opencodebot[bot] commented 5 years ago

This issue is already assigned.

Jigar3 commented 5 years ago

The person solving this, may use https://github.com/ApoorvSaxena/lozad.js this to implement lazy loading

arpitmisraw commented 5 years ago

"Couldn't be solved last time" 😭😭😭

anupm12 commented 5 years ago

@opencodebot claim

opencodebot[bot] commented 5 years ago

This issue is already assigned.

anupm12 commented 5 years ago

Can I try to solve this issue? @Jigar3 @Ace-Bansal

sourabh1031 commented 5 years ago

@opencodebot claim

opencodebot[bot] commented 5 years ago

This issue is already assigned.

sourabh1031 commented 5 years ago

Can i work on this ?

sourabh1031 commented 5 years ago

@anupm12 i think you have been assigned three issues . Can I try on this

anupm12 commented 5 years ago

@anupm12 i think you have been assigned three issues . Can I try on this

@sourabh1031 No. I have 2 issues assigned among those, one I have made a pr already Let me try it once and if I'm unable to do it then you can take it. @Jigar3 @Ace-Bansal @ananya-agrawal @zerefwayne

sourabh1031 commented 5 years ago

Okay @anupm12 :) i will work on it afterwards

vishnuk7 commented 5 years ago

@Jigar3 @Ace-Bansal Can i work on this issue?

ananya commented 5 years ago

@anupm12 so are you working on this?

anupm12 commented 5 years ago

@ananya-agrawal yes I will @opencodebot claim

opencodebot[bot] commented 5 years ago

This issue is assigned to @anupm12.

ananya commented 5 years ago

@anupm12 don't get too many issues assigned to you man :stuck_out_tongue:

anupm12 commented 5 years ago

@ananya-agrawal I'm almost done with the other two na 😅

ananya commented 5 years ago

Haha okay

anupm12 commented 5 years ago

@ananya-agrawal @Ace-Bansal Lazy loading has to be applied to images of all sections right?

ananya commented 5 years ago

@anupm12 yeah

anupm12 commented 5 years ago

@ananya-agrawal I'm making use of lozad.js and when I use data-src property instead of src the images won't load at all. Can you please suggest me some solution to this. Also, I wanted to know fetching data from JSON will be static fetching or dynamic fetching?

anupm12 commented 5 years ago

Mentors please help me.

anupm12 commented 5 years ago

@opencodebot unclaim

opencodebot[bot] commented 5 years ago

@anupm12 is no longer working on this issue.

vishnuk7 commented 5 years ago

@opencodebot claim

opencodebot[bot] commented 5 years ago

This issue is assigned to @vishnuk7.