search

opencodeiiita / Opencode-Collaborative-20

Opencode20 Collabrative website!
https://opencodeiiita.github.io/Opencode-Collaborative-20/
19 stars 156 forks source link

Added footer #391

Closed Cybertron-Avneesh closed 4 years ago

Cybertron-Avneesh commented 4 years ago

371

Fixes #371

Short description of what this resolves:

Created footer https://cybertron-avneesh.github.io/OpencodeFavIcon/

image

Changes proposed in this pull request and/or Screenshots of changes:

-

-

Jigar3 commented 4 years ago

Give proper padding and use some other color for footer background, something that matches with the website

Cybertron-Avneesh commented 4 years ago

@Jigar3 Sir i have updated footer https://cybertron-avneesh.github.io/OpencodeFavIcon/

Jigar3 commented 4 years ago

Still there isn't enough padding Screenshot from 2020-02-13 20-28-21

Cybertron-Avneesh commented 4 years ago

Sir you mean padding for the social icons at top

Cybertron-Avneesh commented 4 years ago

https://cybertron-avneesh.github.io/OpencodeFavIcon/

thesmallstar commented 4 years ago

@Cybertron-Avneesh some padding at the bottom too.

Jigar3 commented 4 years ago

Screenshot from 2020-02-13 22-32-13

You have applied padding only on the top and not towards the bottom

Cybertron-Avneesh commented 4 years ago

Done sir https://cybertron-avneesh.github.io/OpencodeFavIcon/

Jigar3 commented 4 years ago

The footer is not very responsive. Only mobile resolution things can be improved.

Screenshot from 2020-02-14 02-54-29

Cybertron-Avneesh commented 4 years ago

Made footer more responsive. Now on hover social icons get highlighted. https://cybertron-avneesh.github.io/OpencodeFavIcon/ image