search

opencodenitr / hephaestus

A repository for small automation/crazy/game projects by the OpenCode
Apache License 2.0
6 stars 9 forks source link

Leaderboard button on the main menu #45

Open 007vedant opened 2 years ago

007vedant commented 2 years ago

The code presently contains the logic to save top 3 high scores in the backend. This issue aims at implementing a leaderboard button in the main menu to see top 3 highscores.

Hacktoberfest 2021 contributions are welcome 🚀 🎉

bjuspi commented 2 years ago

Hi, can you assign this to me ?

007vedant commented 2 years ago

Hi @bjuspi Glad to assign this issue to you 🚀

bjuspi commented 2 years ago

Hi @bjuspi Glad to assign this issue to you 🚀

Thanks! I have a couple of questions regarding this issue:

  1. How can I get the asset for the main menu button ?
  2. What should the branch name for this issue should be following the contribution guideline naming convention, I'm quite confused ?
007vedant commented 2 years ago

@bjuspi

  1. Assets for the main menu High Scores button will be added soon via #48
  2. As per the contribution guidelines the name of the branch can be feat/Leaderboard button on the main menu
bjuspi commented 2 years ago

@007vedant

Thanks for the reply!

For now I can work using a dummy assets as the placeholder button

007vedant commented 2 years ago

Hi @bjuspi, the assets for main menu High Scores have been added via PR #50. Please consider pulling from upstream and using the assets 🔑 🚀

Assets can be found in /assets/menu with names

  1. high-scores-active.png
  2. high-scores-inactive.png
bjuspi commented 2 years ago

Hi @007vedant, thanks for the update

I've updated my branch, and the asset looks great!

007vedant commented 2 years ago

@bjuspi any updates?