Closed amaneth closed 5 years ago
linas
commented
5 years ago Pull request titles that describe what is actually in the pull request is best!
I mean, this seems like reasonable work; I am not carefully following this project ... and I know you closed this pull req instead of merging... but still, "normal" conventions should be followed.
amaneth
commented
5 years ago thanks!
On Thu, Feb 21, 2019, 11:53 PM Linas Vepštas notifications@github.com wrote:
@linas commented on this pull request.
In act/manual/manualCommands.cpp https://github.com/opencog/TinyCog/pull/33#discussion_r259112305:
+ +map<std::string,int> currentPosition ={{"mouth",0},{"head",0},{"forehead",0},{"eye",0},{"check",0}}; + +map<std::string,std::vector
> pinStore ={ +{mouth,{3,5}}, +{head,{7,12}}, +{eye,{12,13}}, +{forehead,{10,11}}, +{check,{15,16}}, +}; +map<std::string,int> feedbackPinStore ={ +{mouth,19}, +{head,21}, +{forehead,22}, +{eye,23}, +{check,24} Using standard indentation would be nice ...
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/opencog/TinyCog/pull/33#pullrequestreview-206534839, or mute the thread https://github.com/notifications/unsubscribe-auth/AtdShlKoqZoMBvwRtXeyeGn1CzGqe5sZks5vPwcvgaJpZM4bFZFg .
https://github.com/opencog/TinyCog/pull/33/commits/8852e7b1956916d18102beef28f46bf7aa20e7ad