search

opencog / asmoses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search for the AtomSpace (https://github.com/opencog/atomspace)
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
39 stars 31 forks source link

Load data to atomspace #20

Closed Yidnekachew closed 6 years ago

Yidnekachew commented 6 years ago

Implemented based on #12

ngeiswei commented 6 years ago

@Yidnekachew it is OK if you make you next commits on top the existing one (i.e. not overwrite the git history) I mean the branch is clean enough at this point.

ngeiswei commented 6 years ago

@Yidnekachew said

Will it be imperceptible as we're going to do the checking for every single cell in the data?

Yes because the branch prediction of the CPU will choose the right function after the first few cycles.

ngeiswei commented 6 years ago

Last thing @Yidnekachew please fix the warnings (by having the default visitor operators return something, like Handle::UNDEFINED or {}).

ngeiswei commented 6 years ago

I've merged, it seems alright, including the git history.

Thanks for your patience and for putting up with my stringent requirements.

Yidnekachew commented 6 years ago

@ngeiswei It's an honor to get your comments!