search

opencog / asmoses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search for the AtomSpace (https://github.com/opencog/atomspace)
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
39 stars 31 forks source link

Fix vertex bool #62

Closed Eman22S closed 5 years ago

Eman22S commented 5 years ago

Running asmoses -i datasets/fimilar.csv --atomspace-port=1 produced this error:- vertex should be 'id::logical_true' or 'id::logical_false'. I then realized the function that is producing these error happens to have a logic error . When the vertex that is passed to the function vertex_to_bool is either id::logical_true or id::logical_false the function should run properly with no error . The reason behind that is that you cannot convert a logical_and/or/lambda...etc to bool and that is not the purpose of the function vertex_to_bool. But that is not the case with this implementation. It says when vertex is logical_true or logical_false then return an exception which prohibits the function to go forward with the conversion.

ngeiswei commented 5 years ago

@Eman22S , I think you need to create the PR on singnet, not opencog.

Eman22S commented 5 years ago

Sorry was a mistake, I will once I take another look on the issue