search

opencog / asmoses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search for the AtomSpace (https://github.com/opencog/atomspace)
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
38 stars 30 forks source link

Represent problem data in atomspace #8

Closed Yidnekachew closed 6 years ago

Yidnekachew commented 6 years ago

Implemented as per #3

ngeiswei commented 6 years ago

@Yidnekachew I understand that in the long run it is preferable to load data directly from a file to Atomese. However for now it might be simpler to load the data first into a table or ctable (or whatever is at your disposal) and then convert it into Atomese. For instance your loader doesn't support optional header, and maybe other things that I am overseeing.

The other option, perhaps the best one, would be to refactor the table loaders so you can reuse as much as possible from that (as you've done for instance with inferTableAttributes and tokenizeRow) thus keeping a compact code while not having to pay the overhead of creating an temporary table.

ngeiswei commented 6 years ago

@Yidnekachew I think it's better if you close this PR and create a new one, as there is enough changes to apply, and there's a conflict (I know github may resolve that at the press of button but it's still introduces some junk in the git history).

ngeiswei commented 6 years ago

Yes, so what I mean, is that you would rebase your branch onto the master, then remove your commits via a soft reset (to not loose the changes), then apply your modifications, and then create cohesive commits possible by selecting hunks of code rather whole files (if necessary).

Yidnekachew commented 6 years ago

@ngeiswei Thanks for the comments! I'm closing this PR now.