search

opencog / asmoses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search for the AtomSpace (https://github.com/opencog/atomspace)
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
39 stars 31 forks source link

Fix incorrect install paths #82

Closed Habush closed 3 years ago

Habush commented 3 years ago

In CMakeLists.txt the install path is under include/opencog/asmoses/comboreduct/combo. However, there is no comboreduct directory in the current project structure. Instead it should be changed to combo.

Now, if we fix this install path, we will still will run into an error when an external code tries to include the combo library. If we include the header #include <opencog/asmoses/combo/combo/combo.h> in an external source code, the compiler will complain because in combo.h, the include paths don't map to a correct path as the project files are installed under opencog/asmoses not opencog. We can fix this in two ways:

  1. Install everything under opencog directory and not asmoses
  2. Update the project structure and include another directory named asmoses where all the source files reside. Ofcourse, we will also have to update all the header files to reflect the path change

I can send a PR once we agree which option to take.

ngeiswei commented 3 years ago

@Habush, I think we want to keep the full path opencog/asmoses/... even that requires fixing a number of #include, thus go with option 2. It provides a cleaner folder tree structure, which is especially important for asmoses as it is more intertwined with opencog that moses.