search

opencog / asmoses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search for the AtomSpace (https://github.com/opencog/atomspace)
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
38 stars 29 forks source link

Fix install path issues #86

Closed Habush closed 2 years ago

Habush commented 2 years ago

This PR fixes #82 and uses the second approach mentioned in the issue

linas commented 2 years ago

Since I commented on the last pull, I feel obliged to comment here as well. I skimmed this, and it looks fine (after my very superficial skim.)

Habush commented 2 years ago

Thanks @linas. All the targets build without an issue. Some tests still fail which I will fix in another PR

Habush commented 2 years ago

What's the status of this PR? I want to send another PR that fixes the failing unit-tests that is based on this one. Or should include them it in this one?

linas commented 2 years ago

What's the status of this PR?

According to the stats, the lead developer is @kasimebrahim guided by @ngeiswei so they would have to approve and merge. I see that @Bitseat and @Yidnekachew have contributed; maybe they have something to add?

I can merge (or tell you to merge) as a last resort, but these kinds of procedural questions need to be in the hands of the package maintainers.

ngeiswei commented 2 years ago

Thanks @Habush !