opencog / ghost_bridge

A ROS bridge between the Hanson Robotics stack and OpenCog's GHOST
GNU Affero General Public License v3.0
6 stars 11 forks source link

Gaze at #11

Closed SomeUserName1 closed 5 years ago

SomeUserName1 commented 6 years ago

Changes for the riseconf demo Gaze at, singing, neck direction

elggem commented 6 years ago

Hi,

great pull request, good work! I had to figure out what changes were made, so I made a list:

Maybe in the future try documenting in the pull request description changes in more detail, so the reviewer has an easier job.

My only blocking question is about the perception of where the robot is gazing at. As I can see here, you are subscribing to /safe/Neck_Rotation_controller/command which can have arbitrary publishing rate, and then piping that straight to netcat for perception. Might it make sense to throttle this either in code or by republishing using the same method as faces_throttled? Which one is better @jdddog might have an opinion on!

SomeUserName1 commented 6 years ago

@jdddog shall i take the neck stuff out or rather, cap the rate or create a message to only publish on request (and register when served)