Rework tracon hash function

opencog / link-grammar

The CMU Link Grammar natural language parser

GNU Lesser General Public License v2.1

389 stars 118 forks source link

Rework tracon hash function #1485

Closed linas closed 7 months ago

linas commented 8 months ago

Proposed fix for issue found in #1479

The Atomese backend can have 100K upper-case connectors, and no lower-case subscripts. This seems like a good compromise.

linas commented 7 months ago

@ampli I'm merging this now, based on your earlier commentary. If this looks wrong, let me know.

ampli commented 7 months ago

It seems there are still plenty of collisions, even with the new function. In tests conducted with just a small number of "normal" disjuncts, both this function and the original one led to significant collision problems, primarily in a few table entries that experienced the majority of collisions. Currently, I'm diving into debugging to figure this out.