search

opencog / miner

Frequent and surprising subhypergraph pattern miner for the AtomSpace.
Other
8 stars 15 forks source link

Merge singnet/miner to opencog/miner #42

Closed ngeiswei closed 4 years ago

ngeiswei commented 4 years ago

That's what I expected, due to how things have been setup, going from singnet to opencog is more troublesome than going from opencog to singnet. Eventhough it seems it's only a matter of fixing the circleci config.

Options I see

  1. Subsequently fix circleci config on the opencog side, but then going from opencog to singnet will create a similar breakage.
  2. Find a way to make that circleci repo-generic.
  3. Drop circleci altogether it sucks anyway :-D

There's of course the options of always going from opencog to singnet (which I have done so far, for that very reason), or the option of never going from singnet to opencog (which seems a bit extreme, especially if we want to avoid at least artificial divergence between opencog and singnet).

ngeiswei commented 4 years ago

The following PR https://github.com/opencog/miner/pull/46 should address that problem, via way 2. make it repo-generic, so I'm closing this one and retrying.