MinerUTest fails 3 of 51 tests

raschild6 commented 3 years ago

gcc --version: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0

This is the output of cmake ..

-- Build type: Release
-- CogUtil version 2.0.3 found.
-- AtomSpace found.
-- URE found.
-- Boost version 106900 found.
-- Guile (2.2.3 >= 2.2.2) was found.
-- Valgrind Prefix: 
-- VALGRIND was found.
-- VALGRIND devel headers found.

Building for Ubuntu 18.04.5 LTS

The following components will be built:
-----------------------------------------------
   Miner  - URE based hypergraph pattern miner.

-- Configuring done
-- Generating done

build works 100%. Atomspace, opencog, cogutil, ure, other repo.. works

Output of miner make test:

[ 38%] Built target miner
[ 50%] Built target guile-miner
[ 61%] Built target minerutestutils
[ 77%] Built target SurprisingnessUTest
[ 94%] Built target MinerUTest
[ 94%] Built target tests
[100%] Running tests...
Test project /home/michele/OpenCog_ALL/miner/build/tests
    Start 1: MinerUTest
1/2 Test #1: MinerUTest .......................***Failed    4.97 sec
Running cxxtest tests (51 tests)[INFO] BEGIN TEST: test_partitions
.[INFO] BEGIN TEST: test_is_blk_syntax_more_abstract_1
.[INFO] BEGIN TEST: test_is_blk_syntax_more_abstract_2
.[INFO] BEGIN TEST: test_is_blk_syntax_more_abstract_3
.[INFO] BEGIN TEST: test_is_pat_syntax_more_abstract
.[INFO] BEGIN TEST: test_is_pat_more_abstract_1
.[INFO] BEGIN TEST: test_is_pat_more_abstract_2
.[INFO] BEGIN TEST: test_is_pat_more_abstract_3
.[INFO] BEGIN TEST: test_is_more_abstract_foreach_var
.[INFO] BEGIN TEST: test_remove_useless_clauses_1
.[INFO] BEGIN TEST: test_remove_useless_clauses_2
.[INFO] BEGIN TEST: test_remove_useless_clauses_3
.[INFO] BEGIN TEST: test_compose_1
.[INFO] BEGIN TEST: test_compose_2
.[INFO] BEGIN TEST: test_compose_3
.[INFO] BEGIN TEST: test_compose_4
.[INFO] BEGIN TEST: test_expand_conjunction_disconnect
.[INFO] BEGIN TEST: test_expand_conjunction_1
.[INFO] BEGIN TEST: test_expand_conjunction_2
.[INFO] BEGIN TEST: test_expand_conjunction_3
.[INFO] BEGIN TEST: test_expand_conjunction_4
.[INFO] BEGIN TEST: test_shallow_abstract
.[INFO] BEGIN TEST: test_empty
.[INFO] BEGIN TEST: test_A
.[INFO] BEGIN TEST: test_AB
.[INFO] BEGIN TEST: test_AB_redundant_cnj
.[INFO] BEGIN TEST: test_AB_AC
.[INFO] BEGIN TEST: test_AB_AC_BC
.[INFO] BEGIN TEST: test_AB_ABC
.[INFO] BEGIN TEST: test_ABCD
.[INFO] BEGIN TEST: test_ABAB
.[INFO] BEGIN TEST: test_AAAA
.[INFO] BEGIN TEST: test_glob

In MinerUTest::test_glob:
/home/michele/OpenCog_ALL/miner/build/tests/miner/../../../tests/miner/MinerUTest.cxxtest:1345: Error: Assertion failed: content_eq(ure_results, ure_expected)
[INFO] BEGIN TEST: test_transitivity
.[INFO] BEGIN TEST: test_long_transitivity
.[INFO] BEGIN TEST: test_no_transitivity
.[INFO] BEGIN TEST: test_evaluation
.[INFO] BEGIN TEST: test_variable_factorization
.[INFO] BEGIN TEST: test_type_support_1

In MinerUTest::test_type_support_1:
/home/michele/OpenCog_ALL/miner/build/tests/miner/../../../tests/miner/MinerUTest.cxxtest:1544: Error: Assertion failed: content_eq(ure_results, ure_expected)
[INFO] BEGIN TEST: test_type_support_2
In MinerUTest::test_type_support_2:
/home/michele/OpenCog_ALL/miner/build/tests/miner/../../../tests/miner/MinerUTest.cxxtest:1581: Error: Assertion failed: content_eq(ure_results, ure_expected)
[INFO] BEGIN TEST: test_typed_glob
.[INFO] BEGIN TEST: test_2conjuncts_1
.[INFO] BEGIN TEST: test_2conjuncts_2
.[INFO] BEGIN TEST: test_2conjuncts_3
.[INFO] BEGIN TEST: test_2conjuncts_4
.[INFO] BEGIN TEST: test_2conjuncts_5
.[INFO] BEGIN TEST: test_2conjuncts_6
.[INFO] BEGIN TEST: test_InferenceControl
.[INFO] BEGIN TEST: test_SodaDrinker
.[INFO] BEGIN TEST: test_SodaDrinker_incremental
.[INFO] BEGIN TEST: test_vqa
.
Failed 3 and Skipped 0 of 51 tests
Success rate: 94%

Errors in file MinerUTest.cxxtest at lines 1345-1544-1581. The method content_eq(ure_results, ure_expected) in file HandleTree.cc seems not to work in those 3 tests but I tested the output both by hand and using the method itself (I add it into the MinerUTest file and test using it) and so they work.

is there any error in my opencog component installations?

ngeiswei commented 3 years ago

@kasimebrahim, the errors concern glob and type support, do you have any idea what could be causing them?

ngeiswei commented 3 years ago

I believe this has been fixed.

opencog / miner