search

opencog / moses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search. See also AS-MOSES https://github.com/opencog/asmoses but kept to guaranty backward compatibility.
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
127 stars 83 forks source link

Cmake update fix. #32

Closed ArleyRistar closed 8 years ago

ArleyRistar commented 8 years ago

After cmake version 3.2.2 (that's the default for ubuntu 15.10), it had undefined reference problems. It happens in newer versions too, like 3.4.1. The dependency of libcomboreduct and libcomboant was solved in the code. See issue #29 for details. The dependency between libfeature_selection and libmoses was solved updating the interface in the cmake config files. See issue #29 for details. After accepting this pull request, close issue #27 and #29.

ArleyRistar commented 8 years ago

Circleci error. I'll fix it then I'll create another pull request.

ngeiswei commented 8 years ago

@arleyristar you don't need to close and create another PR, you merely need to push you commit on you remote branch and github will automatically update the PR and relaunch circle-ci. Thanks for you help, BTW!

ArleyRistar commented 8 years ago

c++: internal compiler error: Killed (program cc1plus) It's likely a memory issue in the circleci. No idea how to solve it.

linas commented 8 years ago

merged because it built :-)

linas commented 8 years ago

Oh, I see... you're right. Actually, it is considered to be "bad coding practice" to have two classes A and B which derive from a common base, both have a method (static or not) that takes the same argument, but returns two different values. I missed the fact that all of these methods were returning different things, even though they had the same name. That's kind of icky. The whole vertex variant design is kind-of icky, it should be some observer pattern or something. The current saving grace is that (a) it works and (b) doesn't use much RAM, so I guess its OK to leave it as is, but in the future, if we expand to add more types, it should be redesigned.