search

opencog / moses

MOSES Machine Learning: Meta-Optimizing Semantic Evolutionary Search. See also AS-MOSES https://github.com/opencog/asmoses but kept to guaranty backward compatibility.
https://wiki.opencog.org/w/Meta-Optimizing_Semantic_Evolutionary_Search
Other
127 stars 83 forks source link

added division-of-constants reduction rule #54

Closed Yidnekachew closed 7 years ago

Yidnekachew commented 7 years ago

added division-of-constants reduction rule as a fix to this issue

linas commented 7 years ago

Wow! I looked at the code, it looks plausible to me. It would be good if there was a unit test for it, too,

Have you tried simplifying 3*x+2 ? With the old contins, this would not have worked very well, because 2/3 has an infinite binary represention.

This is OK to merge, by me, @ngeiswei do you want to review?

ngeiswei commented 7 years ago

I also requested @Yidnekachew to add a unit test on slack. Then I'll review and merge.