search

opencog / pln

Probabilistic Logic Network (PLN) implemented on top of the Unified Rule Engine (URE). https://wiki.opencog.org/w/Probabilistic_logic_networks
Other
15 stars 19 forks source link

ScopeLinkCast utest #42

Closed linas closed 3 years ago

linas commented 3 years ago

This adds a unit test for the cast to ScopeLink ... it passes (will pass) after pull req opencog/atomspace#2809 is merged.

This pull req is layers on top of pull req #41 that adds the assorted missing atom types that PLN wants.

linas commented 3 years ago

I just ported this unit test to opencog/atomspace#2811

ngeiswei commented 3 years ago

@linas, since you provided that test on the atomspace repo where it belongs I'm gonna close that PR. I'll create another PR if I want to add the spacetime dependency (which should actually be optional as it's only required for the temporal reasoning part of PLN).

linas commented 3 years ago

It would be wise to not have any dependency on spacetime. This is because spacetime, if/when it ever gets fixed, will probably store time in a format that is not suitable for whatever PLN needs. You'll just have compatibility headaches.

There are also a dozen-plus PLN atom definitions in the atomspace, that should probably be moved to PLN. It's not urgent, but it is important.