search

opencog / rocca

Rational OpenCog Controlled Agent (ROCCA). Use OpenCog to control a rational agent in OpenAI Gym and Malmo environments.
GNU Affero General Public License v3.0
30 stars 18 forks source link

Last temporal deduction integration fixes #35

Closed ngeiswei closed 2 years ago

ntoxeg commented 2 years ago

You have modified notebooks — remember to invoke nbdev_build_lib and black or just make rocca.

ngeiswei commented 2 years ago

I'm having some unusual error cannot import name 'html5lib' from 'pip._vendor' but I presume it might come from you, @ntoxeg, updating the image or such.

Also note, @ntoxeg, you'll probably want to rebase #37 (I mean the subsequent one) onto the master cause much of it (black formatting) is present in that PR.

ntoxeg commented 2 years ago

@ngeiswei I’m working on bringing Python 3.10 into the image and doing this properly turned out to be a major pain — specifically there are problems with pip…

ngeiswei commented 2 years ago

@ntoxeg, if Python 3.9 is less of a pain, it's OK too. In terms of type system they're almost the same (Python 3.10 has union type, which is cool, but not dramatically so).

ntoxeg commented 2 years ago

@ngeiswei well, that would require you to pull back some type annotations you’ve made — at this point I’ve made enough progress that I’ll try to see it through, unless I get horribly stuck today I’ll go for 3.10. The thing is, once I have this figured out, then in principle we will always be able to update to the latest Python, if we wish.

ntoxeg commented 2 years ago

@ngeiswei unfortunately I’ve hit a worse-case scenario as it turns out CMake scripts for OpenCog can’t handle multiple Python versions in the system. This means that you can’t use any other Python until I figure out how to improve them and get PRs of that merged. Fortunately CMake nowadays has its own Python support so hopefully migrating to that will fix these issues.