search

opencog / rocca

Rational OpenCog Controlled Agent (ROCCA). Use OpenCog to control a rational agent in OpenAI Gym and Malmo environments.
GNU Affero General Public License v3.0
30 stars 18 forks source link

Fix MalmoWrapper observation / reward order #37

Closed ntoxeg closed 2 years ago

ntoxeg commented 2 years ago

This properly fixes #36.

ntoxeg commented 2 years ago

Bad news: because of the new type annotations I have to upgrade Python in the docker image (not trivial). Until that is done all tests will be failing.

ntoxeg commented 2 years ago

I have a solution to build against Python 3.10 in my images in the works, hopefully tests will be working soon.

ntoxeg commented 2 years ago

Update on the image — it seems maybe installing Cython to user-space actually fixed the problem. On the other hand AtomSpace doesn’t build currently anyway...

ntoxeg commented 2 years ago

I have absolutely no idea why pip still fails in the workflow, this is exactly the problem I have fixed in the image now.

ntoxeg commented 2 years ago

@ngeiswei I think you can merge this, it also changes the workflow to run as non-root as all PyPI packages are user-installed now. As for the broken workflow I really have no idea — I can run the same image and pip is fine, it should be impossible to see such a difference when running the same image...

ntoxeg commented 2 years ago

I’m done for today but I’ve figured out what’s wrong — there are quite a few problems with GitHub Actions idiosyncrasies, I’ll slowly deal with those.

ntoxeg commented 2 years ago

@ngeiswei oof, pip finally works in Github Actions. At this point you can just merge this PR as I went out of scope already.

There are more issues to fix but they are less confusing — like some packages not installing because they build from source (for some reason) and missing development packages. There is also the fact that FindCython brakes in AtomSpace, so the whole thing is not buildable currently. That will take more work but this Actions workflow is now correct — the rest of fixing will be on my Docker image-side, so there is nothing more to do here.

ngeiswei commented 2 years ago

Thanks @ntoxeg !