opencog / ure

Unified Rule Engine. Graph rewriting system for the AtomSpace. Used as reasoning engine for OpenCog.
Other
54 stars 30 forks source link

MapLink no longer returns an invalid handle. #83

Closed linas closed 4 years ago

linas commented 4 years ago

Commit opencog/atomspace#317c1c56e3e18c90b62dbbca62fc86deff46c69d changed how MapLink works ... it no longer returns an invalid handle. Returning the invalid handle resulted in bizarro memory corruption, resulting in crashes in the destructor for class Context and specifically, in the destructor for std::list<Variables>. Getting rid of the null-pointer fixes some unknown null-pointer-deref somewhere else... but it requires this change.

ngeiswei commented 4 years ago

I see, that explains the failing here https://github.com/opencog/atomspace/pull/2616, and I suppose Map returns an empty Set when there is no match now.