opencollab / arpack-ng

Collection of Fortran77 subroutines designed to solve large scale eigenvalue problems.
Other
285 stars 123 forks source link

libparpack built without using FFLAGS when using autotools #448

Open loqs opened 8 months ago

loqs commented 8 months ago

Expected behavior

FFLAGS will be used for all parts of the build.

Actual behavior

FFLAGS are used for everything except libparpack.

Where/how to reproduce the problem

Steps to reproduce the problem

For autotools with the issue:

$ cd arpack-ng
$ ./bootstrap
$ ./configure --enable-icb --enable-mpi --prefix=/usr
$ make
# make install

For cmake without the issue:

$ cd arpack-ng
$ ./bootstrap
$ cmake -DCMAKE_INSTALL_PREFIX='/usr'  -DICB=True -DMPI=True
$ cmake --build
# cmake --install

Notes, remarks

I believe the issue is caused by: https://github.com/opencollab/arpack-ng/blob/40329031ae8deb7c1e26baf8353fa384fc37c251/PARPACK/SRC/MPI/Makefile.am#L4-L5 Removing those lines and both build systems use FFLAGS throughout.

fghoussen commented 8 months ago

Feel free to propose a PR

fghoussen commented 8 months ago

I believe the issue is caused by:

If tested to work at your side, feel free to push this patch