search

opencollab / arpack-ng

Collection of Fortran77 subroutines designed to solve large scale eigenvalue problems.
Other
290 stars 124 forks source link

Make ctests platform independent #461

Closed mmuetzel closed 1 month ago

mmuetzel commented 5 months ago

Pull request purpose

Change configuration of some ctests on Windows so they work "out of the box".

Detailed changes proposed in this pull request

Windows doesn't have a mechanism similar to rpaths. Instead, shared libraries are searched in the current working directory and in the directory with the executable followed by directories in the environment variable PATH.

Add the path to the shared libarpack library to PATH for ctests that run executables that are located in a different directory and that set the current working directory not to the directory with the libarpack.dll. Use a generator expression that should be working independent on the CMake generator.

Also remove the previously added work-around from the CI rules for MinGW that is no longer needed with that change.

mmuetzel commented 1 month ago

I hope the latest change addresses your comments.

fghoussen commented 1 month ago

I hope the latest change addresses your comments.

Yes, thanks!

fghoussen commented 1 month ago

Can you update the changelog?

mmuetzel commented 1 month ago

Is that Changelog entry ok?

mmuetzel commented 1 month ago

@sylvestre: Thank you for merging.

sylvestre commented 1 month ago

thank you for you contrib :)