opencollab / jlatexmath

A Java API to render LaTeX
Other
514 stars 109 forks source link

Maven rework #13

Closed davidmoten closed 7 years ago

davidmoten commented 7 years ago

More work will naturally follow following merge especially with .travis setup and Maven Central release automation.

davidmoten commented 7 years ago

looking at openjdk differences now

davidmoten commented 7 years ago

Yep openjdk and oracle jdk have slight rendering differences. I've

sylvestre commented 7 years ago

Impressive work!

davidmoten commented 7 years ago

Moved the image distance function used in tests in multiple modules to the core jlatexmath artifact in an internal package (any package labelled internal should not be considered part of the public API).

Squashed commits.

calixteman commented 7 years ago

Are you ready to merge this PR ?

davidmoten commented 7 years ago

Are you ready to merge this PR ?

Yep. There is more cleanup stuff like fixing warnings (unused code, unused imports) but I tried to limit the scope of this work to just the multi-artifact refactor and to add tests (so that I knew my work hadn't broken anything). Other fixes can wait for later PRs. I'll also need to update the docs with build instructions (not tricky mvn clean install), and have a chat with you about releases. Consultation with primary users about the new artifact breakdown will be good too.

davidmoten commented 7 years ago

In case I was ambiguous about being ready to merge, yes we are ready to merge. I'll leave it to you when you' are ready @calixteman.

calixteman commented 7 years ago

@davidmoten thanks for your work

davidmoten commented 7 years ago

no probs, thanks for yours!