search

opencollective / opencollective-jobs

MIT License
3 stars 2 forks source link

pull first and last commit #3

Open xdamman opened 8 years ago

xdamman commented 8 years ago

I see that right now in the group.data you only record the number of commits per contributor, can you also add the firstCommitAt and lastCommitAt? E.g. 

{ "githubContributors": { 
  "tj": { 
    "firstCommitAt": "2012-01-01 12:00:11", 
    "lastCommitAt": "2014-01-01 12:00:11",
    "commits": 1292
  },
 ...
}
boneskull commented 8 years ago

we're limited to getting the last commit b/c of our strategy of pulling contributions

boneskull commented 8 years ago

@xdamman Sorry, I made a mistake here; what I said before only applies to external contributions (the "DigitalOcean" use case).

In this case, we are getting contributions via the Repositories API. There's no timestamp info; only a list of contributors, and how many contributions. So to do this, I'd need to either:

a) Combine this data with info from the Events API, which may or may not contain either one of these dates due to its limitations on historical data b) Implement some portion of #5

Unfortunately, I'm not going to have time to do either of these things right now.

xdamman commented 8 years ago

Get something done with the best data that you have without having to refactor everything. If you can only have the last commit so be it, that will already be useful data to have.

boneskull commented 8 years ago

@xdamman That would be option a), which I still won't have time to do right now.

xdamman commented 8 years ago

How long would that take and when would you have time for that?

boneskull commented 8 years ago

@xdamman see slack reply

xdamman commented 8 years ago

Would it be easy to add avatar, website and email (if any) easily to group.data.githubContributors ?

boneskull commented 8 years ago

Yes, I believe that would be straightforward, and similar to how I explained what needs to happen in Slack

On Fri, Jun 17, 2016 at 5:01 PM Xavier Damman notifications@github.com wrote:

Would it be easy to add avatar, website and email (if any) easily to group.data.githubContributors ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenCollective/opencollective-jobs/issues/3#issuecomment-226907753, or mute the thread https://github.com/notifications/unsubscribe/AA4bMZS8JvOpk-usEEO69r-IJ4dWgBFtks5qMzVRgaJpZM4I4tjQ .

Christopher Hiller https://boneskull.com | https://github.com/boneskull