opencollective / opencollective-website

OpenCollective frontend
MIT License
62 stars 38 forks source link

Update info about how to submit an expense #797

Closed alanna closed 6 years ago

piamancini commented 6 years ago

tests are not passing. You might have an html tag broken.

alanna commented 6 years ago

Grrr I double checked all the HTML tags and I can't figure out why the tests are failing. I tried to read the CircleCI report, but I'm having trouble finding the part where it says what exactly is wrong? @xdamman maybe you could have a look?

@piamancini the one bit of this content I thought could use a little more info is the part about tax forms. It links the forms but doesn't say what they are for or who needs to fill them out (or who to submit them to). What can be said about those?

xdamman commented 6 years ago

Some of that info should be put in the new expense policy feature at the level of the host.

xdamman commented 6 years ago
11:16:03 js.1     |  SyntaxError: /Users/xdamman/github/opencollective/website/frontend/src/containers/Faq.js: Expected corresponding JSX closing tag for <br> (117:10) while parsing file: /Users/xdamman/github/opencollective/website/fron…
11:16:04 web.1    |  /Users/xdamman/github/opencollective/website/node_modules/babel-core/lib/transformation/file/index.js:573
11:16:04 web.1    |        throw err;
11:16:04 web.1    |        ^
11:16:04 web.1    |  SyntaxError: /Users/xdamman/github/opencollective/website/frontend/src/containers/Faq.js: Expected corresponding JSX closing tag for <br> (117:10)
11:16:04 web.1    |    115 |             Walnut CA 91789<br>
11:16:04 web.1    |    116 |             USA
11:16:04 web.1    |  > 117 |           </p>
11:16:04 web.1    |        |           ^
11:16:04 web.1    |    118 |               <p>
11:16:04 web.1    |    119 |                Private information provided on invoices is not viewable publicly. The expense amount will be listed on the Collective page, but the invoice itself is only visible to the host and core contribu…
11:16:04 web.1    |    120 |          </p>
xdamman commented 6 years ago

The problem was that you needed to use <br /> instead of <br>. It was hard for you to know. No worries, thank you for trying (and now you know for next time! :-) )