search

opencollective / opencollective

We're tracking all our Issues, RFCs and a few other documents in this repository.
https://opencollective.com
MIT License
2.01k stars 371 forks source link

activity updates in expense comments #1071

Closed alanna closed 4 years ago

alanna commented 6 years ago

Now that we have comments on expenses, it would be great if activity status updates appeared there as well. For example: "expense submitted by [name]", "expense approved by [core contributor name]", "file xyz uploaded", "expense edited by [name]", "expense paid". Having these notes with the dates on them would be very useful for record keeping and figuring out any confusion or mistakes.

xdamman commented 6 years ago

I like that.

I wonder what would be the best way to implement that and also implement "reactions" (👍 🎉❤️...) and multiple levels of approval (e.g. approved by Xavier and Alanna).

One way I can think about it is to have a special type of comment "activity" or "reaction". The flip side of it would be to abstract everything as an "activity" of type "comment", "approval", "reaction".

I probably like the latter better but it conflicts with our current Activity table. That said, this really needs to be updated.

Other things to consider: entities. We should be able to mention someone in a comment.

I'd be curious to know how is Github handling this behind the scene.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

alanna commented 5 years ago

We still need this

mixmix commented 5 years ago

Alanna re-opened this because I was asking her how I figure out who approved an expense for someone to go to a conference on my OC group.

e.g. I'm looking at this expense : https://opencollective.com/secure-scuttlebutt-consortium/expenses/6503 and can't see very much info at all

image [ DOM edited to hide user name + email ]

alanna commented 5 years ago

Bumping this, because it keeps coming up....

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. We want to keep it in our todo list but haven't had the time to address it yet. Thank you for your contributions!

alanna commented 5 years ago

This should be included in the new expense flow design @raulgrafico

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. We want to keep it in our todo list but haven't had the time to address it yet. Thank you for your contributions!

Betree commented 4 years ago

Implemented in https://github.com/opencollective/opencollective-frontend/pull/3893, will be resolved with the new expense flow release

Betree commented 4 years ago

Implemented in the new expense flow

mixmix commented 4 years ago

Hooray! <3

On Tue, 12 May 2020, 22:52 Benjamin Piouffle, notifications@github.com wrote:

Closed #1071 https://github.com/opencollective/opencollective/issues/1071.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/opencollective/opencollective/issues/1071#event-3326915103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUK3HRDZGI32UJAEFQLLFTRRES7XANCNFSM4E66POYA .