opencollective / opencollective

We're tracking all our Issues, RFCs and a few other documents in this repository.
https://opencollective.com
MIT License
1.99k stars 365 forks source link

h1 renders poorly in updates #6265

Open RichardLitt opened 1 year ago

RichardLitt commented 1 year ago

Describe the bug Using <h1> as the first item in an update renders poorly when published.

To Reproduce

Take a look at https://opencollective.com/sequelize/updates/release-of-sequelize-v6-27-0.

Expected behavior There should be padding for H1 in the box, or text shouldn't be clipped.

Screenshots

Screenshot 2023-01-02 at 17 02 09

Desktop (please complete the following information):

Triage Template (core team only) This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0: P1 high frequency, high impact P2 low frequency, high impact P3 high frequency, low impact P4 low frequency, low impact Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround. High frequency - >10% of users affected (measured as a proportion of total potential users for this case).
Betree commented 1 year ago

You're not supposed to have h1 in updates, the RichTextEditor is supposed to prevent that (the actual h1 is the update title). To be confirmed, but I assume sequelize has an automation to publish these updates and the API itself doesn't try to downscale titles. We could fix that by switching this mainTitles flag to false for updates, but we should investigate in the DB to make sure this won't impact other updates.