search

opencommunitymap / communitymap-cloud-functions

API and microservices of Open Community Map
https://communitymap.online/
Apache License 2.0
1 stars 2 forks source link

Replace Tslint with Eslint #6

Open prescottprue opened 4 years ago

prescottprue commented 4 years ago

TSLint is now deprecated as described in their article about it. For typescript projects I have now been using eslint directly with @typescript-eslint/eslint-plugin and @typescript-eslint/parser (as seen in cypress-firebase). This also makes it easy to integrate tools like prettier.

If you want I can work on switching things over if you would like - If so, do you have a linting preference in mind? Common styles include airbnb linting (semis and trailing commas) and standardjs linting (no unnecessary semis or trailing commas)

dmitry-yudakov commented 4 years ago

Yes, it sounds like the right thing to do.

I don't have some strong opinions about linters :)

I do use prettier with default settings as it makes my coding life a bit easier :)

I notice now I put .prettierrc in the UI repo but missed to put it here. I think I've put its default settings probably with the idea of having it unchanged if they decide to change some default option in the next major version. I'm not sure if it's a good strategy and am totally ok with changing it.

As for the style, though semis create some noice they are good for avoiding some strange js bugs. And trailing commas are good for clearer diffs. What do you think? Do have preferences or advice?