search

opencompany / www.opencompany.org

Website of the Open Company Initiative
https://www.opencompany.org
Other
61 stars 37 forks source link

provide ruby version to fix the travis build #172

Closed waldyrious closed 8 years ago

waldyrious commented 8 years ago

The build currently errors out with: Gem::InstallError: public_suffix requires Ruby version >= 2.0.

waldyrious commented 8 years ago

Test: update pull request after Travis has been set up to build on pull requests (the setting was off before, not sure why)

waldyrious commented 8 years ago

Okay, closing and reopening the pull request successfully triggered the build. Let's see how it goes...

galuszkak commented 8 years ago

@waldyrious if you need help with that I'm quite familiar. But opening pull request shouldn't trigger build only commits in master. If this isn't the case we should fix that.

waldyrious commented 8 years ago

But opening pull request shouldn't trigger build only commits in master

Why not? That would prevent merging of PRs that break the build. Or did I misunderstand you?

galuszkak commented 8 years ago

@waldyrious if deploy breaks it's our problem. But with deploying on Pull Request, basically anyone outside Open Company can create damaging PR that will deploy automatically to our production site. This isn't desired behaviour as we want to be accept/reject PR and then deploy automatically website.

waldyrious commented 8 years ago

We must be talking about different things. I am talking about triggering a build on Travis when a PR is created, not deploying to the live site. That allows us to see if the build fails in advance, and fix any issues before merging the PR and thus deploying the change live.

galuszkak commented 8 years ago

@waldyrious Travis is used not to build but for deploy website. This isn't seperated right now. "Build" now is just deploying new website from commit that went to Travis for build. (see .travis.yml file)

waldyrious commented 8 years ago

Oh, I see. I hadn't seen that setup before. Isn't there a way to get the builds separate from the deployment? It'd would be a pity to miss out on the opportunity to know whether a PR breaks the site before we merge it...

techtonik commented 8 years ago

@waldyrious deploy only on tags - https://docs.travis-ci.com/user/deployment/releases