search

opencompany / www.opencompany.org

Website of the Open Company Initiative
https://www.opencompany.org
Other
61 stars 37 forks source link

use SmartyPants for smart punctuation #81

Closed chadwhitacre closed 10 years ago

chadwhitacre commented 10 years ago

Care to look into this, @kyzh? SmartyPants gives us conversion of quotes to smart quotes, etc. in markdown files. Might need a different markdown processor, though:

https://github.com/blog/706-jekyll-puts-on-smartypants

kyzh commented 10 years ago

Sure, I'll look into it. I will try to provide feedback tomorrow around this time

kyzh commented 10 years ago

It seems to work fine with rdiscount and the option set to smart. Will push the change to both repo in a sec.

kyzh commented 10 years ago

Well the diff is quite big on the generated html. Here is an example

-<p>Le Sommet de 2014 aura lieu le 22 Mars à San Francisco. Nous prévoyons l&#39;événement
-via <a href="https://github.com/opencompany/www.opencompany.org/issues/5">GitHub</a>.</p>
+
+
+
+<p>Le Sommet de 2014 aura lieu le 22 Mars à San Francisco. Nous prévoyons l'événement
+via [GitHub] (https://github.com/opencompany/www.opencompany.org/issues/5).</p>
+
+

here is the full diff : http://pastebin.com/CseUn7E0 I know you are busy @whit537 but i could do with a second pair of eyes/ fresher brain

chadwhitacre commented 10 years ago

@kyzh Most of that diff looks whitespace-related, no?

kyzh commented 10 years ago

@whit537 there is some accent that were using &#39 instead of the charater ' I pushed it nevertheless, we will see if anyone complain.