opencomponents / oc-client-browser

The OpenComponents Browser client
MIT License
6 stars 8 forks source link

remove logic of api returning a "rendered" response as it can't happen #118

Closed ricardo-devis-agullo closed 2 months ago

ricardo-devis-agullo commented 2 months ago

I'm looking at the logic, and for both calls (render and getData), we use the getHeaders function that always add the header Accept: 'application/vnd.oc.unrendered+json' to the request.

When that happens, the response is always going to be unrendered, with one single exception, which is when oc-client-node calls the endpoint and the template is not supported (see here). This can only happen with node, where the node client will send a specific oc-client user agent string, so I don't see how it can ever happen in a browser context.

I got to think that some time ago this code was somehow moved from server to client and found it's way there, but I think is 100% safe to remove.