search

opencomponents / oc-client-browser

The OpenComponents Browser client
MIT License
6 stars 8 forks source link

Make sure prettier picks up eslintrc #19

Closed pbazydlo closed 7 years ago

pbazydlo commented 7 years ago

When trying to create another PR prettier rewrote all ' to ". This PR forces it to use .eslintrc which was ignored for some reason.

pbazydlo commented 7 years ago

/cc @nickbalestra @matteofigus

pbazydlo commented 7 years ago

Travis is failing, but it seems there's something wrong on the build pipeline that should not be related to this PR:

15 10 2017 05:41:35.280:ERROR [launcher.sauce]: Can not start chrome 48 (Linux)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
15 10 2017 05:41:35.283:ERROR [launcher.sauce]: Can not start firefox 45 (Linux)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
15 10 2017 05:41:35.283:ERROR [launcher.sauce]: Can not start android 5.1 (Linux)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
matteofigus commented 7 years ago

@pbazydlo you can't execute the tests if you making a fork PR. That's how SauceLabs works. Make a new branch on origin and reopen your PR. The tests then should be green.

I am sorry I didn't realise this earlier.

matteofigus commented 7 years ago

Created a Contributing file to clarify: https://github.com/opencomponents/oc-client-browser/blob/master/CONTRIBUTING.md