search

opencomponents / oc-client-browser

The OpenComponents Browser client
MIT License
6 stars 8 forks source link

ESLint Improvements #41

Closed bassettsj closed 6 years ago

bassettsj commented 6 years ago

Changes:

  1. make rules more enforced across the code base
  2. fix errors found in the source code
  3. ignore vendor files that are checked into git

I can remove the package-lock if you want as well.

bassettsj commented 6 years ago

This was the only reason I did this:

screen shot 2018-02-09 at 2 57 22 pm

👀

matteofigus commented 6 years ago

@bassettsj thanks for your contribution and sorry for getting back to you so late.

I made you admin, for the time being can you make all the other PRs in new upstream branches, so that sencha should be able to run? We'll clean that up when moving to jest 💃