opencomponents / oc-client-browser

The OpenComponents Browser client
MIT License
6 stars 8 forks source link

loading jquery only if it does not exist #9

Closed debopamsengupta closed 7 years ago

debopamsengupta commented 7 years ago

this should solve #8

cc @nickbalestra @mattiaerre

mattiaerre commented 7 years ago

hi @debopamsengupta thanks for this; have you been able to test it locally? if so how did you do that? thanks,

debopamsengupta commented 7 years ago

@mattiaerre I was testing the script locally on a test page....the current tests are probably not geared towards testing the loading of jQuery based on existing page settings

nickbalestra commented 7 years ago

Awesome, thanks 💯 @debopamsengupta ! Can you patch the version? Then I'll merge/publish it

debopamsengupta commented 7 years ago

@nickbalestra does the existing oc-client package need to be bumped as well ? to use new oc-client-browser ?

nickbalestra commented 7 years ago

@debopamsengupta yes i see that we didn't enabled greenkeeper on those repos, I've updated let see if it works, otherwise I'll do it manually. Thanks for the heads up