opencomponents / oc-client-node

The OpenComponents Node client
13 stars 12 forks source link

renderComponents is not defined #94

Closed Melonbwead closed 5 years ago

Melonbwead commented 5 years ago

I'm getting a renderComponents is not defined error when i try to call the client.init function, using version "^3.2.4" of the module and node.js version 6.10.0.

Here's the code where i was calling the init function: https://gist.github.com/ChennyBaBy/b04ffe0e3f069d0d5608718ba12ea39a

I think i'm missing something obvious but i couldn't figure out what im missing from the readme.

path/to/node_modules/oc-client/src/index.js:34
      const renderComponents = options.renderComponents || renderComponents;
                                                           ^
ReferenceError: renderComponents is not defined
wsalazar-peakactivity commented 5 years ago

I'm getting the same thing. Were you able to work around this? Any insights would be helpful.

wsalazar-peakactivity commented 5 years ago

I have an open pr that fixes the issue on my side: https://github.com/opencomponents/oc-client-node/pull/95

matteofigus commented 5 years ago

Merged and released. Thanks!