opencomponents / oc

OpenComponents, serverless in the front-end world for painless micro-frontends delivery
https://opencomponents.github.io/
MIT License
1.43k stars 122 forks source link

dont install when packaging at all #1371

Closed ricardo-devis-agullo closed 3 months ago

ricardo-devis-agullo commented 3 months ago

handle-dependencies module will, among other things, install missing dependencies if found. This only makes sense for when running oc dev, since you want to replicate the behaviour of a real registry, where the dependencies are served by the registry (in this case the parent folder where oc dev is running from), but it's not needed when packaging/publishing, since there is no registry running involved.

Because both commands (dev/package) use the same file, they share the same logic and did the same. This resulted in somebody having an issue when doing this install on CI (https://github.com/opencomponents/oc/issues/943), and then a new variable was created, useComponentDependencies, to not install when packaging, but rather doing a symlink. But this wasn't needed at all, since AFAIK packaging doesn't require those dependencies anyways. So this PRs removes that option, the logic to symlink, and simplifies by having an internal install option that will be true for oc dev, but false for oc package and oc publish